[fhomess]

Originally Posted by dangarion

Ok just going to free flow some observations and some suggestions. Just to give you a background I used to run BOSI for the RWBL as well, so I have used tools like this in the past.

It would be nice if the tool would show the SQL import progress. Especially since the import of a large league (that has the full MLB history data) takes upwards of 10 minutes.

Also if there is an issue with a SQL import is there a way to revert and do it again?

I'm also having some type of issue with the financials since my SQL Log keeps showing this for all the teams in the league.

LOADING: team_last_financials.mysql.sql ... 237
   insert into `team_last_financials` VALUES (31, 41306087, 29565975, 16372701, 0, 0, 0, 10000000, 79733000, 7200000, 0, 2630961, 0, 0, 0, 0.0000, 0, 0, 91200000, 0, 0, ,1,1);
 -> You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near '1,1)' at line 1
   insert into `team_last_financials` VALUES (32, 44920259, 34783500, 21813997, 0, 0, 0, 10000000, 95662500, 7930000, 0, 2861163, 0, 0, 0, 0.0000, 0, 0, 108200000, 0, 0, ,1,1);
 -> You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near '1,1)' at line 1
   insert into `team_last_financials` VALUES (33, 41306087, 29565975, 18711658, 0, 0, 0, 10000000, 81197000, 8970000, 0, 2630961, 0, 0, 0, 0.0000, 0, 0, 94500000, 0, 0, ,1,1);
 -> You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near '1,1)' at line 1
   insert into `team_last_financials` VALUES (34, 51794560, 45218550, 25992582, 0, 0, 0, 10000000, 123155308, 7280000, 0, 2999106, 0, 0, 0, 0.0000, 0, 0, 135500000, 0, 0, ,1,1);
 -> You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near '1,1)' at line 1
   insert into `team_last_financials` VALUES (35, 44920259, 34783500, 22734952, 0, 0, 0, 10000000, 97257500, 8000000, 0, 2861163, 0, 0, 0, 0.0000, 0, 0, 109900000, 0, 0, ,1,1);
 -> You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near '1,1)' at line 1
   insert into `team_last_financials` VALUES (36, 57363462, 45218550, 31280296, 0, 0, 0, 10000000, 136253500, 7590000, 0, 3321567, 0, 0, 0, 0.0000, 0, 0, 149200000, 0, 0, ,1,1);

Yeah, large loads can take a while due to the size of the files and sheer quantity of data to import. There's a couple of things that can be done. First, don't load SQL files you don't need. For example, the team_last_financials.mysql.sql file that you're getting the above error in isn't used by the utilities anywhere. There are actually a handful of other SQL files that will throw errors when imported by the utility that you don't need, and these will slow down the load. Second, I've uploaded a modification to the utilties that will allow you to load files individually. There's some detail in the documentation and a new link on the main admin page to another page where you can load individual files. Some folks have had issues with the load script timing out if the file is too big and their PHP install isn't configured to accept the script's request for additional time. This individual page load will hopefully help with that.

There isn't a way to revert the SQL and do it again because of the way OOTP has decided to provide the data. Their method is to delete the whole table, then rebuild it completely, so once it's deleted it's lost.

Originally Posted by dangarion

I know there are team filters but it would also be nice to see all the data without a filter, and even positional filters in the areas that it's possible (any area that has the drop downs to only via each team, career metrics, development, ratings).

I know you did it for security reasons, but all the blank fields on the admin screen can be sort of confusing to people, especially to those that are used to seeing information in fields like that listed in other web scripts (phpBB, etc). Maybe include some text that they are blank for security reasons, still difficult to tell if the settings are correct though, not sure what you could do.

Talking about security, I've been forced to move our league exports to a separate UNIX user on the server, and unfortunately that makes it impossible for the script to see the folders that user has access to (the commish user is the web access account, and the export user only has access to it's own folders, unsure if there is a way to work around that with the export tracker or not, don't worry about it, just thought I would mention it.) I'm guessing there wouldn't be a way for me to resolve this unless if I did it on my own by like running a cron job or something, but even that would be a PITA.

Overall this tool is awesome! Really like what I'm seeing, and love that it was integrated in with the existing league reports.

I'll have to think about some of these and see what I might do.

Originally Posted by dangarion

One more thing. I've also noticed that sometimes after it has appeared to run it's course of importing, if I attempt to go back to it, it hangs for quite sometime. I'm wondering if that is because it's actually still importing (this is why showing the activity might be useful. I wish the SQL files were so big, this is a pretty big import compared to what I'm used to.

I tried to petition the dev team to provide incremental SQL data dumps, like maybe for just the past season, but to no avail. Perhaps as this tool gets more widespread use, they'll see the benefits of making that available. There's really no need to include 90 years of history in the SQL dump every time.

Originally Posted by dangarion

Ah i got another one. If you go to career metrics and look at the team index. The W-L record for all the teams in 2008 is messed up.

Minnesota Twins History - Index - StatsLab for OOTPX

I'll send you a PM on this one.

Originally Posted by dangarion

Last one! I promise!

I didn't read anywhere in the manual about having to go to the Development Tracker admin and checking boxes to get the development to actually show. That explains why I wasn't able to see development.

Added to the documentation.