Historical database issues thread

[Spritze]

It depends on the function you are using. In general it is fixed.

The team name is "San Diego Padres - Minors" in the Teams.csv which is what sets up the league demographics. If your function does not use that setup then you will not see the change.

[Amazin69]

"Function"? I just did the "create a new historical league" with "import complete history up until [year of league]" and "import historic minors (1915+) checked…seemed fairly standard, AFAI could tell. What triggers the Padres bug, exactly?

And I see that we have a similar bug for the pre-1954 Baltimore Orioles; players on those minor-league teams are credited with being part of the major-league St. Louis Browns, who would of course eventually become the Orioles. (Bob Lemon, who pitched for the 1942 Orioles and the 1958 Padres, is subject to both of these bugs.) Same issue?

On a different note, I see that the game is retiring an inexplicably-high portion of players as 1Bs, for whatever reason. I'm only looking up 1969 coaches (as per our discussion in the other thread) and already I've seen Jim Gilliam, Yogi Berra and Lemon listed as 1Bs. Rather 1Bizarre, I'd say…

[Spritze]

And the Los Angeles Angels and the Buffalo Bisons and many more. That said when I create a historical league with real minors I do not have this issue. What is your year of league? That is probably the cause?

For retired players the game does not keep prior historical fielding records in its data and every player without a fielding record automagically becomes a first baseman upon unretirement. I have whined about this for a few years but a change does not seem to be in the cards.

[Amazin69]

I'm trying to set up a 1969 league. A fun year, IM admittedly-biased O, but not anything that should trigger bugs…unless it's that it's the first season of the MLB Padres. (But that wouldn't account for the Orioles/Browns issue, I shouldn't think.)

So minor-league Bisons players have their stats displayed as if they were ML-level Buf-Feds? That's so very wrong, it's almost cool…

[Spritze]

There was a Buffalo Bisons MLB team in the 1800's.

I created a 1969 historical league with full minors and see no challenges. Orioles/Browns nor Padres.

[Amazin69]

Well, as noted, Bob Lemon, "veteran" of both the 1942 Browns and 1958 Padres, would disagree:



Could this be due to my using a Mac? Or did my tweaking the financials (to compensate for the "everybody's making WAY to much money" issue, as noted in my other thread) have triggered this? Odd.

[Spritze]

Unretirement is the trigger but the fix was rolled back at some point and is no longer in place.

[Amazin69]

I'm sure there was a perfectly good reason for unfixing the fix, but still.

So I guess this makes it all the more imperative that I help out with that "historic coaching positions" project, hmm? So that all of this can be pre-loaded and there will be no need to unretire players. Okay, then.

Thanks for the help.

[cultbuscus]

Doing a long-term sim from the beginning of time (1871) just to peak at drafts.

The 1967 (Thurman Munson and co.) and 1984 (McGwire/Maddux) drafts did not load. They seem to be imported at the end of the year as free agents, after the World Series the next year.

Other drafts are importing just fine. The years prior and the years after all imported as expected.

[Spritze]

Originally Posted by cultbuscus

Doing a long-term sim from the beginning of time (1871) just to peak at drafts.

The 1967 (Thurman Munson and co.) and 1984 (McGwire/Maddux) drafts did not load. They seem to be imported at the end of the year as free agents, after the World Series the next year.

Other drafts are importing just fine. The years prior and the years after all imported as expected.

The drafts are all the same and run through the same process so of ideas I have none. As others have not reported this issue for those years I suspect you had a temporary glitch.

[Supermercado]

Frank O'Rourke - o'roufr01
Frank O'Rourke - orourfr01 and orourk002jam

Same person. Picked this up when they appeared on the same side.

[Spritze]

Not finding this challenge so it must have been fixed for OOTP19

[royhobbs]

I think I've found some potential duplicates/errors in the Master.csv. Apologies if these have already been reported or if I am wrong about any of this.

I'm attaching qry_Duplicates_In_Master by BBrefMiLBid.

This is a query of the Master.csv for records with identical BBrefMiLBids.

There are 20 records, constituting ten pairs of records with identical BBrefMiLBids.

In the case of eight of the pairs, there is one record with what I believe to be an incorrect playerid. For example, there are two entries for Scott Alexander. alexasc02 is the correct playerid for him. alexasc01 is not. I've denoted the incorrect entry in the comment field by "Duplicate. Wrong playerid." I believe these duplicate records should be deleted, as they do not refer to a player. Additionally, I cannot import a player using those playerids. Additionally, for the record with the correct playerid, I've included the Baseball Reference link for verification.

The remaining two pairs of duplicates have different issues.

One of the pairs is actually two different players. Jim Callahan and John W Callahan both have playerids of "callaji01," but Jim Callahan's should be "callaji02." I've noted this in the CorrectPlayerID field and provided links to their Baseball Reference pages.

The final pair of duplicates share a BBrefMiLBid of "obrien001tom" but have different playerids. As I note in the Comment field, the BBrefMiLBid "obrien001tom" belongs to the playerid "o'brito01," not playerid "o'brija01." It is currently associated with both. I believe it should be disassociated with "o'brija01," whom I do not believe has a BBrefMiLBid.

Please let me know if any of this is unclear or wrong or if you have any questions.

Thank you for your work.

-Roy

EDIT: Jim Callahan (correct playerid=callaji02) and John W Callahan (correct playerid=callaji01) both have a BBrefMiLBid of "callah018---" associated with them. I don't believe this BBrefMLBid should be associated with either one.

The correct BBrefMLBid for Jim Callahan (correct playerid=callaji02) should be callah004jam. See here.

The correct BBrefMLBid for John W Callahan (correct playerid=callaji01) should be callah004joh. See here

-Roy

[royhobbs]

Attached is a query for duplicates in MiLB master where either BBrefMinorsID is the same or BBrefMLBid is the same. I've listed in the comments suggestion what I believe is wrong with a particular entry and suggested a fix. Again, apologies if these are old news, already fixed, incorrect or I am misunderstanding something.

For those reasons, I believe the following:

1. RowID=422561 should be deleted because it is a duplicate of RowID=422562 with incorrect birth date and birth city.
2. RowID=423111 should be deleted. It is a duplicate of RowID=423110.
3. RowID=423116 should be deleted. RowID=423117 is the same player and has identical information the only difference being that RowID=423116 lists the player's first name as Dalton whereas RowID=423117 lists the player's first name as Tolly. Google reveals inconsistent reports about whether he was born Dalton or Tolly Filotei, but his Baseball Reference page is under Tolly Filotei and does not list Dalton. See here.
4. RowID=424559 should be deleted. It is a duplicate of RowID=104624. Additionally, RowID=424559 has an incorrect birth city listed.
5. RowID=20020 should have its BBrefMLBid corrected. It has an incorrect BBrefMLBid for this BBrefMinorsID. The correct one is callaji02. See here.
6. RowID=20034 has an incorrect BBrefMLBid for this BBrefMinorsID. There is no associated BBrefMLBid for this BBrefMinorsID. See here.
7. RowID=109877 has an incorrect BBrefMLBid for this BBrefMinorsID. The BBrefMLBid should be changed to penato03. See here.
8. RowID=116152 has the incorrect BBrefMLBid for this BBrefMinorsID. There is no BBrefMLBid for this BBrefMinorsId. See here.
9. RowID=145477 has the incorrect BBrefMLBid for this BbrefMinorsID. There is no BBrefMLBid for this BBrefMinorsId. See here.

Thanks for your work.

-Roy

[Spritze]

Originally Posted by royhobbs

I think I've found some potential duplicates/errors in the Master.csv. Apologies if these have already been reported or if I am wrong about any of this.

I'm attaching qry_Duplicates_In_Master by BBrefMiLBid.

This is a query of the Master.csv for records with identical BBrefMiLBids.

There are 20 records, constituting ten pairs of records with identical BBrefMiLBids.

In the case of eight of the pairs, there is one record with what I believe to be an incorrect playerid. For example, there are two entries for Scott Alexander. alexasc02 is the correct playerid for him. alexasc01 is not. I've denoted the incorrect entry in the comment field by "Duplicate. Wrong playerid." I believe these duplicate records should be deleted, as they do not refer to a player. Additionally, I cannot import a player using those playerids. Additionally, for the record with the correct playerid, I've included the Baseball Reference link for verification. Fixed

The remaining two pairs of duplicates have different issues.

One of the pairs is actually two different players. Jim Callahan and John W Callahan both have playerids of "callaji01," but Jim Callahan's should be "callaji02." I've noted this in the CorrectPlayerID field and provided links to their Baseball Reference pages. Fixed

The final pair of duplicates share a BBrefMiLBid of "obrien001tom" but have different playerids. As I note in the Comment field, the BBrefMiLBid "obrien001tom" belongs to the playerid "o'brito01," not
The correct BBrefMLBid for John W Callahan (correct playerid=callaji01) should be callah004joh. See here Fixed

-Roy

I'll mark these up as I get them done

[Spritze]

Originally Posted by royhobbs

Attached is a query for duplicates in MiLB master where either BBrefMinorsID is the same or BBrefMLBid is the same. I've listed in the comments suggestion what I believe is wrong with a particular entry and suggested a fix. Again, apologies if these are old news, already fixed, incorrect or I am misunderstanding something.

For those reasons, I believe the following:

1. RowID=422561 should be deleted because it is a duplicate of RowID=422562 with incorrect birth date and birth city.
2. RowID=423111 should be deleted. It is a duplicate of RowID=423110.
3. RowID=423116 should be deleted. RowID=423117 is the same player and has identical information the only difference being that RowID=423116 lists the player's first name as Dalton whereas RowID=423117 lists the player's first name as Tolly. Google reveals inconsistent reports about whether he was born Dalton or Tolly Filotei, but his Baseball Reference page is under Tolly Filotei and does not list Dalton. See here.
4. RowID=424559 should be deleted. It is a duplicate of RowID=104624. Additionally, RowID=424559 has an incorrect birth city listed.
5. RowID=20020 should have its BBrefMLBid corrected. It has an incorrect BBrefMLBid for this BBrefMinorsID. The correct one is callaji02. See here.
6. RowID=20034 has an incorrect BBrefMLBid for this BBrefMinorsID. There is no associated BBrefMLBid for this BBrefMinorsID. See here.
7. RowID=109877 has an incorrect BBrefMLBid for this BBrefMinorsID. The BBrefMLBid should be changed to penato03. See here.
8. RowID=116152 has the incorrect BBrefMLBid for this BBrefMinorsID. There is no BBrefMLBid for this BBrefMinorsId. See here.
9. RowID=145477 has the incorrect BBrefMLBid for this BbrefMinorsID. There is no BBrefMLBid for this BBrefMinorsId. See here.

Thanks for your work.

-Roy

All are fixed

[royhobbs]

Spritze:

Encountered a few more issues with Master.csv and MilbMaster.csv. Most have to do with matching IDs, but a couple were related to date information.

They are chronicled in the attached CSV along with suggested fix.

To understand the CSV:

1) Where Source=Master, that refers to a record from the Master.csv. Where Source=Minors, that refers to a record from the MilbMaster.csv

2) Where Source=Master, "Minors ID" refers to "BBrefMiLBid" and "Majors ID" refers to "playerid." Where Source=Minors, "Minors ID" refers to the field "BBrefMinorsID" and "Majors ID" refers to the field "BBrefMLBid."

3) The "Comment" field contains a description of the problem and suggested fix.

4) Where appropriate, I have provided the suggested replacement Minors ID or Majors ID.

Please let me know if you have any questions.

Thank you for your work.

-Roy

[Spritze]

Some of the "missing" ID's are just because OOTP uses multiple databases (7 or 8) not just BBref so many of these records do exist elsewhere just not in BBref and indeed the MiLB player ID's in those cases are completely made up and you will not find them on BBref.

Another issue is the "ballplayer" one. Markus asked that we combine some of these records so that fewer "ballplayers" exist. If a player had a gap in a certain year but a "ballplayer" with the same last name and position had stats for that year their records were combined.

These are due to OOTP being a game and not a baseball encyclopedia. We just use stats to generate ratings.

I will check all 40 of your notes and make any changes required. They will appear in OOTP19 lord willing and the creeks don't rise.

[The Game]

Zack Wheeler imports as Zach Wheeler.
1st Zach is from ootp 12 (originally) 2nd is from 18.When i change the 2nd to Zack and hit reload FG his FG comes up.
I dont know if i changed the 1st Zack before.

[Spritze]

name changed to Zack in MLB and MiLB databases