Bug in data export

ctorg · 10-23-2007, 11:18 AM

I know this exists in both Access and csv exports.

If you have a historical league where you have imported the entire league history, in the league_history_pitching_stats file, the column bsvp (I don't even know what this is) is reported as "-1.#IND" for all imported seasons.

ctorg · 10-23-2007, 11:47 AM

The same thing happens in the team_history_pitching_stats file.

Tony M · 10-27-2007, 04:14 AM

Can't say I've seen that in any of the exports I've looked at, but I think that bsvp is Blown Save Percentage (at least that's what I call it in my code)

Does this only occur in historical leagues with a full imported history. If so, I'll create one and have a look to see what actually appears in the league history in world.dat and teams.dat

Tony M · 10-27-2007, 04:20 AM

A quick look at Lahman and it's clear that in the pitching.csv there is a column for SV but not for SVO or BS.

That would result in the calculation BS/SVO returning a division by zero error when calculating it before outputing to CSV or Access.

But as the field BSVP is stored in the history (one of my bugbears that derived stats are saved in the database when they can be derived from other fields), I'll have a look and see what it contains.

Tony M · 10-27-2007, 04:52 AM

OK, I created a historical league in 1945 with complete history, and had a look at the pitching stats for the Americans for 1901 in teams.dat.

The value stored in BSVP is in hexadecimal 00 00 00 00 00 00 f8 ff which comes out as a value of 3.1493*10^-319 which in Visual Basic and Visual C++ gets classed as NaN (not a number) if you have the type defined as double, and the normal way for this to be output is as -1.#IND

The bug I would say is down to the fact that this value is stored in the database, if the exports put 0 in for a SVO of 0 it would get round it. Then again the database could also contain 0 for an SVO of 0.

Nutlaw · 11-20-2007, 09:29 AM

Did you guys pin this down? What exactly should be logged here?

Tony M · 11-20-2007, 09:37 AM

Quote:

Originally Posted by Nutlaw

Did you guys pin this down? What exactly should be logged here?

The value of -1.#IND is just how an indeterminately small value is represented, and is therefore just expected behaviour.

10-23-2007, 11:18 AM	#1
ctorg Global Moderator Join Date: Nov 2002 Location: Queens, NY Posts: 9,848	Bug in data export I know this exists in both Access and csv exports. If you have a historical league where you have imported the entire league history, in the league_history_pitching_stats file, the column bsvp (I don't even know what this is) is reported as "-1.#IND" for all imported seasons. __________________ My music "When the trees blow back and forth, that's what makes the wind." - Steven Wright Fjord emena pancreas thorax fornicate marmalade morpheme proteolysis smaxa cabana offal srue vitriol grope hallelujah lentils

10-23-2007, 11:47 AM	#2
ctorg Global Moderator Join Date: Nov 2002 Location: Queens, NY Posts: 9,848	The same thing happens in the team_history_pitching_stats file. __________________ My music "When the trees blow back and forth, that's what makes the wind." - Steven Wright Fjord emena pancreas thorax fornicate marmalade morpheme proteolysis smaxa cabana offal srue vitriol grope hallelujah lentils

10-27-2007, 04:14 AM	#3
Tony M Global Moderator Join Date: Feb 2006 Location: Here Posts: 6,156	Can't say I've seen that in any of the exports I've looked at, but I think that bsvp is Blown Save Percentage (at least that's what I call it in my code) Does this only occur in historical leagues with a full imported history. If so, I'll create one and have a look to see what actually appears in the league history in world.dat and teams.dat __________________ This signature is intentionally blank

10-27-2007, 04:20 AM	#4
Tony M Global Moderator Join Date: Feb 2006 Location: Here Posts: 6,156	A quick look at Lahman and it's clear that in the pitching.csv there is a column for SV but not for SVO or BS. That would result in the calculation BS/SVO returning a division by zero error when calculating it before outputing to CSV or Access. But as the field BSVP is stored in the history (one of my bugbears that derived stats are saved in the database when they can be derived from other fields), I'll have a look and see what it contains. __________________ This signature is intentionally blank

10-27-2007, 04:52 AM	#5
Tony M Global Moderator Join Date: Feb 2006 Location: Here Posts: 6,156	OK, I created a historical league in 1945 with complete history, and had a look at the pitching stats for the Americans for 1901 in teams.dat. The value stored in BSVP is in hexadecimal 00 00 00 00 00 00 f8 ff which comes out as a value of 3.1493*10^-319 which in Visual Basic and Visual C++ gets classed as NaN (not a number) if you have the type defined as double, and the normal way for this to be output is as -1.#IND The bug I would say is down to the fact that this value is stored in the database, if the exports put 0 in for a SVO of 0 it would get round it. Then again the database could also contain 0 for an SVO of 0. __________________ This signature is intentionally blank

11-20-2007, 09:29 AM	#6
Nutlaw Hall Of Famer Join Date: Apr 2003 Posts: 9,538	Did you guys pin this down? What exactly should be logged here?